Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d695a1be authored by Markus Elfring's avatar Markus Elfring Committed by Theodore Ts'o
Browse files

ext4: use sizeof(*ptr) 



Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
parent 1bd8d6cd

fs/ext4/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ static struct dir_private_info *ext4_htree_create_dir_info(struct file *filp, 
{

	struct dir_private_info *p;



	p = kzalloc(sizeof(struct dir_private_info), GFP_KERNEL);

	p = kzalloc(sizeof(*p), GFP_KERNEL);

	if (!p)

		return NULL;

	p->curr_hash = pos2maj_hash(filp, pos);

fs/ext4/mmp.c

+1 −1
Original line number Diff line number Diff line
@@ -367,7 +367,7 @@ int ext4_multi_mount_protect(struct super_block *sb, 
		goto failed;

	}



	mmpd_data = kmalloc(sizeof(struct mmpd_data), GFP_KERNEL);

	mmpd_data = kmalloc(sizeof(*mmpd_data), GFP_KERNEL);

	if (!mmpd_data) {

		ext4_warning(sb, "not enough memory for mmpd_data");

		goto failed;