Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4d9823a authored by Vishalsingh Hajeri's avatar Vishalsingh Hajeri Committed by Gerrit - the friendly Code Review server
Browse files

msm: camera: sensor: Assign power settings pointer to null 



Power settings pointers are assigned null after being freed.
This will make sure pointers do not point to some junk memory.

Change-Id: I85df098fc28f0afe9f765ddf7e22cc082e437753
Signed-off-by: default avatarVishalsingh Hajeri <vhajeri@codeaurora.org>
parent 23636c33

drivers/media/platform/msm/camera/cam_sensor_module/cam_actuator/cam_actuator_core.c

+1 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ int32_t cam_actuator_construct_default_power_setting( 


free_power_settings:

	kfree(power_info->power_setting);

	power_info->power_setting = NULL;

	return rc;

}

drivers/media/platform/msm/camera/cam_sensor_module/cam_actuator/cam_actuator_dev.c

+4 −0
Original line number Diff line number Diff line
@@ -252,6 +252,8 @@ static int32_t cam_actuator_platform_remove(struct platform_device *pdev) 
	a_ctrl->io_master_info.cci_client = NULL;

	kfree(power_info->power_setting);

	kfree(power_info->power_down_setting);

	power_info->power_setting = NULL;

	power_info->power_down_setting = NULL;

	kfree(a_ctrl->soc_info.soc_private);

	kfree(a_ctrl->i2c_data.per_frame);

	a_ctrl->i2c_data.per_frame = NULL;
@@ -284,6 +286,8 @@ static int32_t cam_actuator_driver_i2c_remove(struct i2c_client *client) 
	kfree(power_info->power_setting);

	kfree(power_info->power_down_setting);

	kfree(a_ctrl->soc_info.soc_private);

	power_info->power_setting = NULL;

	power_info->power_down_setting = NULL;

	a_ctrl->soc_info.soc_private = NULL;

	kfree(a_ctrl);

	return rc;

drivers/media/platform/msm/camera/cam_sensor_module/cam_ois/cam_ois_core.c

+1 −0
Original line number Diff line number Diff line
@@ -55,6 +55,7 @@ int32_t cam_ois_construct_default_power_setting( 


free_power_settings:

	kfree(power_info->power_setting);

	power_info->power_setting = NULL;

	return rc;

}

drivers/media/platform/msm/camera/cam_sensor_module/cam_ois/cam_ois_dev.c

+4 −0
Original line number Diff line number Diff line
@@ -240,6 +240,8 @@ static int cam_ois_i2c_driver_remove(struct i2c_client *client) 


	kfree(power_info->power_setting);

	kfree(power_info->power_down_setting);

	power_info->power_setting = NULL;

	power_info->power_down_setting = NULL;

	kfree(o_ctrl->soc_info.soc_private);

	kfree(o_ctrl);
@@ -341,6 +343,8 @@ static int cam_ois_platform_driver_remove(struct platform_device *pdev) 


	kfree(power_info->power_setting);

	kfree(power_info->power_down_setting);

	power_info->power_setting = NULL;

	power_info->power_down_setting = NULL;

	kfree(o_ctrl->soc_info.soc_private);

	kfree(o_ctrl->io_master_info.cci_client);

	kfree(o_ctrl);