Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d441b688 authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

net: mvneta: Use kmalloc_array() in mvneta_txq_init() 



A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d6312ed

drivers/net/ethernet/marvell/mvneta.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -2933,7 +2933,8 @@ static int mvneta_txq_init(struct mvneta_port *pp, 
	mvreg_write(pp, MVNETA_TXQ_BASE_ADDR_REG(txq->id), txq->descs_phys);

	mvreg_write(pp, MVNETA_TXQ_BASE_ADDR_REG(txq->id), txq->descs_phys);

	mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), txq->size);

	mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), txq->size);





	txq->tx_skb = kmalloc(txq->size * sizeof(*txq->tx_skb), GFP_KERNEL);

	txq->tx_skb = kmalloc_array(txq->size, sizeof(*txq->tx_skb),

				    GFP_KERNEL);

	if (txq->tx_skb == NULL) {

	if (txq->tx_skb == NULL) {

		dma_free_coherent(pp->dev->dev.parent,

		dma_free_coherent(pp->dev->dev.parent,

				  txq->size * MVNETA_DESC_ALIGNED_SIZE,

				  txq->size * MVNETA_DESC_ALIGNED_SIZE,