Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d339727c authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: graceful exit from netif_alloc_netdev_queues() 



User space can crash kernel with

ip link add ifb10 numtxqueues 100000 type ifb

We must replace a BUG_ON() by proper test and return -EINVAL for
crazy values.

Fixes: 60877a32 ("net: allow large number of tx queues")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 142b942a

net/core/dev.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -6409,7 +6409,8 @@ static int netif_alloc_netdev_queues(struct net_device *dev) 
	struct netdev_queue *tx;

	struct netdev_queue *tx;

	size_t sz = count * sizeof(*tx);

	size_t sz = count * sizeof(*tx);





	BUG_ON(count < 1 || count > 0xffff);

	if (count < 1 || count > 0xffff)

		return -EINVAL;





	tx = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);

	tx = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);

	if (!tx) {

	if (!tx) {