Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2941651 authored by Julia Lawall's avatar Julia Lawall Committed by Anton Vorontsov
Browse files

ab8500_fg: Fix error return code 

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
parent 05cdbdb9

drivers/power/ab8500_fg.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -2506,6 +2506,7 @@ static int __devinit ab8500_fg_probe(struct platform_device *pdev) 
	di->fg_wq = create_singlethread_workqueue("ab8500_fg_wq");

	di->fg_wq = create_singlethread_workqueue("ab8500_fg_wq");

	if (di->fg_wq == NULL) {

	if (di->fg_wq == NULL) {

		dev_err(di->dev, "failed to create work queue\n");

		dev_err(di->dev, "failed to create work queue\n");

		ret = -ENOMEM;

		goto free_device_info;

		goto free_device_info;

	}

	}