Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d254aaec authored by kbuild test robot's avatar kbuild test robot Committed by Dave Chinner
Browse files

xfs: fix simple_return.cocci warning in xfs_bmse_shift_one 



fs/xfs/libxfs/xfs_bmap.c:5591:1-6: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Brian Foster <bfoster@redhat.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
parent 8300475e

fs/xfs/libxfs/xfs_bmap.c

+1 −5
Original line number Original line Diff line number Diff line
@@ -5592,12 +5592,8 @@ xfs_bmse_shift_one( 
	XFS_WANT_CORRUPTED_GOTO(i == 1, out_error);

	XFS_WANT_CORRUPTED_GOTO(i == 1, out_error);





	got.br_startoff = startoff;

	got.br_startoff = startoff;

	error = xfs_bmbt_update(cur, got.br_startoff, got.br_startblock,

	return xfs_bmbt_update(cur, got.br_startoff, got.br_startblock,

				got.br_blockcount, got.br_state);

				got.br_blockcount, got.br_state);

	if (error)

		return error;



	return 0;





out_error:

out_error:

	return error;

	return error;