Commit d24cdcd3 authored Jan 16, 2017 by Arnd Bergmann Committed by Ilya Dryomov Feb 20, 2017

libceph: use BUG() instead of BUG_ON(1)



I ran into this compile warning, which is the result of BUG_ON(1)
not always leading to the compiler treating the code path as
unreachable:

    include/linux/ceph/osdmap.h: In function 'ceph_can_shift_osds':
    include/linux/ceph/osdmap.h:62:1: error: control reaches end of non-void function [-Werror=return-type]

Using BUG() here avoids the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent eb65b919

include/linux/ceph/osdmap.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@ static inline bool ceph_can_shift_osds(struct ceph_pg_pool_info *pool)
		case CEPH_POOL_TYPE_EC:
		return false;
		default:
		BUG_ON(1);
		BUG();
		}
		}