Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2110224 authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: testmgr - use kmemdup instead of kmalloc+memcpy 



It's recommended to use kmemdup instead of kmalloc followed by memcpy.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4cf06628

crypto/testmgr.c

+2 −4
Original line number Diff line number Diff line
@@ -1463,13 +1463,12 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate, 
		int ilen = ctemplate[i].inlen;

		void *input_vec;



		input_vec = kmalloc(ilen, GFP_KERNEL);

		input_vec = kmemdup(ctemplate[i].input, ilen, GFP_KERNEL);

		if (!input_vec) {

			ret = -ENOMEM;

			goto out;

		}



		memcpy(input_vec, ctemplate[i].input, ilen);

		memset(output, 0, dlen);

		init_completion(&result.completion);

		sg_init_one(&src, input_vec, ilen);
@@ -1525,13 +1524,12 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate, 
		int ilen = dtemplate[i].inlen;

		void *input_vec;



		input_vec = kmalloc(ilen, GFP_KERNEL);

		input_vec = kmemdup(dtemplate[i].input, ilen, GFP_KERNEL);

		if (!input_vec) {

			ret = -ENOMEM;

			goto out;

		}



		memcpy(input_vec, dtemplate[i].input, ilen);

		memset(output, 0, dlen);

		init_completion(&result.completion);

		sg_init_one(&src, input_vec, ilen);