Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1c7073b authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart (VMware)
Browse files

platform/x86: fujitsu-laptop: simplify error handling in acpi_fujitsu_laptop_add() 



As LED class devices registered by fujitsu-laptop no longer depend on
the platform device, two function calls inside acpi_fujitsu_laptop_add()
can be rearranged in order to simplify error handling.

Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Reviewed-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 30943e14

drivers/platform/x86/fujitsu-laptop.c

+3 −5
Original line number Diff line number Diff line
@@ -845,18 +845,16 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device) 
			fujitsu_bl->bl_device->props.power = FB_BLANK_UNBLANK;

	}



	error = fujitsu_laptop_platform_add();

	error = acpi_fujitsu_laptop_leds_register(device);

	if (error)

		goto err_free_fifo;



	error = acpi_fujitsu_laptop_leds_register(device);

	error = fujitsu_laptop_platform_add();

	if (error)

		goto err_remove_platform_device;

		goto err_free_fifo;



	return 0;



err_remove_platform_device:

	fujitsu_laptop_platform_remove();

err_free_fifo:

	kfifo_free(&fujitsu_laptop->fifo);

err_stop: