Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1728389 authored by Deepak Kumar's avatar Deepak Kumar Committed by Gerrit - the friendly Code Review server
Browse files

msm: kgsl: Prevent race condition when freeing memory 



Add a check to set the pending_free flag if it is not already
set before freeing sparse memory entry. This is required to
prevent multiple ioctl threads from freeing the same sparse
memory entry.

Change-Id: I8752ced6b639e4c5d13a59e27b2643569d009096
Signed-off-by: default avatarDeepak Kumar <dkumar@codeaurora.org>
Signed-off-by: default avatarUrvashi Agrawal <urvaagra@codeaurora.org>
parent bb9bfbc6

drivers/gpu/msm/kgsl.c

+12 −0
Original line number Diff line number Diff line
@@ -3422,7 +3422,13 @@ long kgsl_ioctl_sparse_phys_free(struct kgsl_device_private *dev_priv, 
	if (entry == NULL)

		return -EINVAL;



	if (!kgsl_mem_entry_set_pend(entry)) {

		kgsl_mem_entry_put(entry);

		return -EBUSY;

	}



	if (entry->memdesc.cur_bindings != 0) {

		kgsl_mem_entry_unset_pend(entry);

		kgsl_mem_entry_put(entry);

		return -EINVAL;

	}
@@ -3491,7 +3497,13 @@ long kgsl_ioctl_sparse_virt_free(struct kgsl_device_private *dev_priv, 
	if (entry == NULL)

		return -EINVAL;



	if (!kgsl_mem_entry_set_pend(entry)) {

		kgsl_mem_entry_put(entry);

		return -EBUSY;

	}



	if (entry->bind_tree.rb_node != NULL) {

		kgsl_mem_entry_unset_pend(entry);

		kgsl_mem_entry_put(entry);

		return -EINVAL;

	}