Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d140199a authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller
Browse files

bpf, lpm: fix kfree of im_node in trie_update_elem 



We need to initialize im_node to NULL, otherwise in case of error path
it gets passed to kfree() as uninitialized pointer.

Fixes: b95a5c4d ("bpf: add a longest prefix match trie map implementation")
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2acc76cb

kernel/bpf/lpm_trie.c

+1 −1
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ static int trie_update_elem(struct bpf_map *map, 
			    void *_key, void *value, u64 flags)

{

	struct lpm_trie *trie = container_of(map, struct lpm_trie, map);

	struct lpm_trie_node *node, *im_node, *new_node = NULL;

	struct lpm_trie_node *node, *im_node = NULL, *new_node = NULL;

	struct lpm_trie_node __rcu **slot;

	struct bpf_lpm_trie_key *key = _key;

	unsigned long irq_flags;