Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d07c0278 authored by Jaedon Shin's avatar Jaedon Shin Committed by David S. Miller
Browse files

net: bcmgenet: Fix internal PHY link state 



The PHY link state is not chaged in GENETv2 caused by the previous
commit 49f7a471 ("net: bcmgenet: Properly configure PHY to ignore
interrupt") was set to PHY_IGNORE_INTERRUPT in bcmgenet_mii_probe().

The internal PHY should use phy_mac_interrupt() when not in use
PHY_POLL. The statement for phy_mac_interrupt() has two conditions. The
first condition to check GENET_HAS_MDIO_INTR is not related PHY link
state, so this patch removes it.

Fixes: 49f7a471 ("net: bcmgenet: Properly configure PHY to ignore interrupt")
Signed-off-by: default avatarJaedon Shin <jaedon.shin@gmail.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 18eceb81

drivers/net/ethernet/broadcom/genet/bcmgenet.c

+1 −2
Original line number Diff line number Diff line
@@ -2445,8 +2445,7 @@ static void bcmgenet_irq_task(struct work_struct *work) 
	}



	/* Link UP/DOWN event */

	if ((priv->hw_params->flags & GENET_HAS_MDIO_INTR) &&

	    (priv->irq0_stat & UMAC_IRQ_LINK_EVENT)) {

	if (priv->irq0_stat & UMAC_IRQ_LINK_EVENT) {

		phy_mac_interrupt(priv->phydev,

				  !!(priv->irq0_stat & UMAC_IRQ_LINK_UP));

		priv->irq0_stat &= ~UMAC_IRQ_LINK_EVENT;