Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce0b15d1 authored by stephen hemminger's avatar stephen hemminger Committed by David S. Miller
Browse files

xgbe: constify get_netdev_ops and get_ethtool_ops 



Casting away const is bad practice. Since this is ARM specific driver
don't have hardware actually test this.

Having getter functions for ops is really unnecessary code bloat, but
not going to touch that.

Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 07469f8c

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+2 −2
Original line number Diff line number Diff line
@@ -1708,9 +1708,9 @@ static const struct net_device_ops xgbe_netdev_ops = { 
	.ndo_set_features	= xgbe_set_features,

};



struct net_device_ops *xgbe_get_netdev_ops(void)

const struct net_device_ops *xgbe_get_netdev_ops(void)

{

	return (struct net_device_ops *)&xgbe_netdev_ops;

	return &xgbe_netdev_ops;

}



static void xgbe_rx_refresh(struct xgbe_channel *channel)

drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -623,7 +623,7 @@ static const struct ethtool_ops xgbe_ethtool_ops = { 
	.get_ts_info = xgbe_get_ts_info,

};



struct ethtool_ops *xgbe_get_ethtool_ops(void)

const struct ethtool_ops *xgbe_get_ethtool_ops(void)

{

	return (struct ethtool_ops *)&xgbe_ethtool_ops;

	return &xgbe_ethtool_ops;

}

drivers/net/ethernet/amd/xgbe/xgbe.h

+3 −2
Original line number Diff line number Diff line
@@ -956,8 +956,9 @@ struct xgbe_prv_data { 
void xgbe_init_function_ptrs_dev(struct xgbe_hw_if *);

void xgbe_init_function_ptrs_phy(struct xgbe_phy_if *);

void xgbe_init_function_ptrs_desc(struct xgbe_desc_if *);

struct net_device_ops *xgbe_get_netdev_ops(void);

struct ethtool_ops *xgbe_get_ethtool_ops(void);

const struct net_device_ops *xgbe_get_netdev_ops(void);

const struct ethtool_ops *xgbe_get_ethtool_ops(void);



#ifdef CONFIG_AMD_XGBE_DCB

const struct dcbnl_rtnl_ops *xgbe_get_dcbnl_ops(void);

#endif