Commit cdcffc0c authored Sep 22, 2016 by Eva Rachel Retuya Committed by Greg Kroah-Hartman Sep 23, 2016

staging: greybus: arche-platform: declare struct of_device_id as const



Declare the arrays 'arche_platform_of_match' and 'arche_combined_id' as const.

'arche_platform_of_match' is only stored in the .of_match_table field of a
device_driver structure, which is declared as const.

'arche_combined_id' is passed to MODULE_DEVICE_TABLE. This macro does not
modify the array and therefore the array can be declared as const. Checkpatch
pointed out both issues.

WARNING: struct of_device_id should be normally const

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a04c28d0

drivers/staging/greybus/arche-platform.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -776,12 +776,12 @@ static SIMPLE_DEV_PM_OPS(arche_platform_pm_ops,
		arche_platform_suspend,
		arche_platform_resume);

		static struct of_device_id arche_platform_of_match[] = {
		static const struct of_device_id arche_platform_of_match[] = {
		{ .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
		{ },
		};

		static struct of_device_id arche_combined_id[] = {
		static const struct of_device_id arche_combined_id[] = {
		{ .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
		{ .compatible = "usbffff,2", },
		{ },