Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc91542a authored by Eric Biggers's avatar Eric Biggers Committed by Theodore Ts'o
Browse files

ext4: do not unnecessarily null-terminate encrypted symlink data 



Null-terminating the fscrypt_symlink_data on read is unnecessary because
it is not string data --- it contains binary ciphertext.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent e81d4477

fs/ext4/symlink.c

+0 −2
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ static const char *ext4_encrypted_get_link(struct dentry *dentry, 
	char *caddr, *paddr = NULL;

	struct fscrypt_str cstr, pstr;

	struct fscrypt_symlink_data *sd;

	loff_t size = min_t(loff_t, i_size_read(inode), PAGE_SIZE - 1);

	int res;

	u32 max_size = inode->i_sb->s_blocksize;
@@ -49,7 +48,6 @@ static const char *ext4_encrypted_get_link(struct dentry *dentry, 
		if (IS_ERR(cpage))

			return ERR_CAST(cpage);

		caddr = page_address(cpage);

		caddr[size] = 0;

	}



	/* Symlink is encrypted */