Commit cc60d8ba authored Aug 01, 2007 by Mariusz Kozlowski Committed by Bartlomiej Zolnierkiewicz Aug 01, 2007

drivers/ide/arm/icside.c: kmalloc + memset conversion to kzalloc



Is this a bug? In original verison memset cleared sizeof(state) bytes
instead of sizeof(*state). If it was intentional then this patch is invalid.
If not intentional -> valid :) Please review.

Bart: Yes, it is a bug so this patch is a valid bugfix. :-)

 drivers/ide/arm/icside.c | 18883 -> 18849 (-34 bytes)

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

parent ab057968

drivers/ide/arm/icside.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -693,13 +693,12 @@ icside_probe(struct expansion_card ec, const struct ecard_id id)
		if (ret)
		goto out;

		state = kmalloc(sizeof(struct icside_state), GFP_KERNEL);
		state = kzalloc(sizeof(struct icside_state), GFP_KERNEL);
		if (!state) {
		ret = -ENOMEM;
		goto release;
		}

		memset(state, 0, sizeof(state));
		state->type = ICS_TYPE_NOTYPE;
		state->dev = &ec->dev;