Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc21942b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones
Browse files

backlight: lcd: Fix race condition during register 



Once device_register is called for a device its attributes might be
accessed. As the callbacks of a lcd device's attributes make use of the
lcd_ops, the respective member must be setup before calling
device_register.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 7ce7d89f

drivers/video/backlight/lcd.c

+2 −2
Original line number Diff line number Diff line
@@ -226,6 +226,8 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent, 
	dev_set_name(&new_ld->dev, "%s", name);

	dev_set_drvdata(&new_ld->dev, devdata);



	new_ld->ops = ops;



	rc = device_register(&new_ld->dev);

	if (rc) {

		put_device(&new_ld->dev);
@@ -238,8 +240,6 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent, 
		return ERR_PTR(rc);

	}



	new_ld->ops = ops;



	return new_ld;

}

EXPORT_SYMBOL(lcd_device_register);