Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc17e129 authored by Dong Aisheng's avatar Dong Aisheng Committed by Ulf Hansson
Browse files

mmc: sdhci-esdhc-imx: restore watermark level setting after resume 



Currently, we config the watermark_level register only in probe.
This will cause the mmc write operation timeout issue after system
resume back in LPSR mode. Because in LPSR mode, after system resume
back, the watermark_level register(0x44) changes to 0x08000880, which
set the write watermark level as 0, and set the read watermark level
as 128. This value is incorrect.

This patch restores the setting of watermark level register after
system resume back.

Signed-off-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 04143fba

drivers/mmc/host/sdhci-esdhc-imx.c

+10 −1
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ 
#define  ESDHC_VENDOR_SPEC_VSELECT	(1 << 1)

#define  ESDHC_VENDOR_SPEC_FRC_SDCLK_ON	(1 << 8)

#define ESDHC_WTMK_LVL			0x44

#define  ESDHC_WTMK_DEFAULT_VAL		0x10401040

#define ESDHC_MIX_CTRL			0x48

#define  ESDHC_MIX_CTRL_DDREN		(1 << 3)

#define  ESDHC_MIX_CTRL_AC23EN		(1 << 7)
@@ -1157,7 +1158,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) 
	 * to something insane.  Change it back here.

	 */

	if (esdhc_is_usdhc(imx_data)) {

		writel(0x10401040, host->ioaddr + ESDHC_WTMK_LVL);

		writel(ESDHC_WTMK_DEFAULT_VAL, host->ioaddr + ESDHC_WTMK_LVL);



		host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;

		host->mmc->caps |= MMC_CAP_1_8V_DDR;
@@ -1261,6 +1262,14 @@ static int sdhci_esdhc_suspend(struct device *dev) 


static int sdhci_esdhc_resume(struct device *dev)

{

	struct sdhci_host *host = dev_get_drvdata(dev);

	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);

	struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host);



	/* restore watermark setting in case it's lost in low power mode */

	if (esdhc_is_usdhc(imx_data))

		writel(ESDHC_WTMK_DEFAULT_VAL, host->ioaddr + ESDHC_WTMK_LVL);



	return sdhci_pltfm_resume(dev);

}