Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb3f491d authored by Chase Southwood's avatar Chase Southwood Committed by Greg Kroah-Hartman
Browse files

staging: comedi: dt3000: remove unneeded variable 



Coccinelle (using scripts/coccinelle/tests/doublebitand.cocci) found this
assignment because 0 is or'd twice.  Upon inspection, I found that the
variable "mode" is only assigned once and used once, and thus can be
cleanly removed.  This patch plugs its value straight into writew() and
then removes the variable.

Signed-off-by: default avatarChase Southwood <chase.southwood@gmail.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b5283aab

drivers/staging/comedi/drivers/dt3000.c

+1 −3
Original line number Diff line number Diff line
@@ -488,7 +488,6 @@ static int dt3k_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) 
	unsigned int chan, range, aref;

	unsigned int divider;

	unsigned int tscandiv;

	unsigned int mode;



	for (i = 0; i < cmd->chanlist_len; i++) {

		chan = CR_CHAN(cmd->chanlist[i]);
@@ -513,8 +512,7 @@ static int dt3k_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) 
		writew((tscandiv & 0xffff), dev->mmio + DPR_Params(4));

	}



	mode = DT3000_AD_RETRIG_INTERNAL | 0 | 0;

	writew(mode, dev->mmio + DPR_Params(5));

	writew(DT3000_AD_RETRIG_INTERNAL, dev->mmio + DPR_Params(5));

	writew(aref == AREF_DIFF, dev->mmio + DPR_Params(6));



	writew(AI_FIFO_DEPTH / 2, dev->mmio + DPR_Params(7));