Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca976c53 authored by Roel Kluin's avatar Roel Kluin Committed by Linus Torvalds
Browse files

smbfs: read buffer overflow 



This function uses signed integers for the unix_date and local variables -
if a negative number is supplied and the leap-year condition is not met,
month will be 0, leading to a read of day_n[-1]

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fa081b00

fs/smbfs/proc.c

+1 −1
Original line number Diff line number Diff line
@@ -509,7 +509,7 @@ date_unix2dos(struct smb_sb_info *server, 
		month = 2;

	} else {

		nl_day = (year & 3) || day <= 59 ? day : day - 1;

		for (month = 0; month < 12; month++)

		for (month = 1; month < 12; month++)

			if (day_n[month] > nl_day)

				break;

	}