Commit ca231f83 authored Apr 01, 2014 by Dan Carpenter Committed by David S. Miller Apr 01, 2014

net: sxgbe: sxgbe_mdio_register() frees the bus



"err" is always zero at this point so we always unregister and free the
mdio_bus before returning success.  This seems like left over code and
I have deleted it.

Fixes: 1edb9ca6 ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 52ad762b

drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c

+0 −7

Original line number	Original line	Diff line number	Diff line
	@@ -219,13 +219,6 @@ int sxgbe_mdio_register(struct net_device *ndev)
	}		}
	}		}

	if (!err) {
	netdev_err(ndev, "PHY not found\n");
	mdiobus_unregister(mdio_bus);
	mdiobus_free(mdio_bus);
	goto mdiobus_err;
	}

	priv->mii = mdio_bus;		priv->mii = mdio_bus;

	return 0;		return 0;