Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca09907d authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: mos7720.c: remove dbg() tracing calls 



dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b69919ca

drivers/usb/serial/mos7720.c

+14 −20
Original line number Diff line number Diff line
@@ -257,7 +257,6 @@ static void destroy_mos_parport(struct kref *kref) 
	struct mos7715_parport *mos_parport =

		container_of(kref, struct mos7715_parport, ref_count);



	dbg("%s called", __func__);

	kfree(mos_parport);

}
@@ -266,7 +265,7 @@ static void destroy_urbtracker(struct kref *kref) 
	struct urbtracker *urbtrack =

		container_of(kref, struct urbtracker, ref_count);

	struct mos7715_parport *mos_parport = urbtrack->mos_parport;

	dbg("%s called", __func__);



	usb_free_urb(urbtrack->urb);

	kfree(urbtrack);

	kref_put(&mos_parport->ref_count, destroy_mos_parport);
@@ -285,8 +284,6 @@ static void send_deferred_urbs(unsigned long _mos_parport) 
	struct urbtracker *urbtrack;

	struct list_head *cursor, *next;



	dbg("%s called", __func__);



	/* if release function ran, game over */

	if (unlikely(mos_parport->serial == NULL))

		return;
@@ -335,7 +332,7 @@ static void async_complete(struct urb *urb) 
{

	struct urbtracker *urbtrack = urb->context;

	int status = urb->status;

	dbg("%s called", __func__);



	if (unlikely(status))

		dbg("%s - nonzero urb status received: %d", __func__, status);
@@ -355,7 +352,6 @@ static int write_parport_reg_nonblock(struct mos7715_parport *mos_parport, 
	struct usb_ctrlrequest setup;

	struct usb_serial *serial = mos_parport->serial;

	struct usb_device *usbdev = serial->dev;

	dbg("%s called", __func__);



	/* create and initialize the control urb and containing urbtracker */

	urbtrack = kmalloc(sizeof(struct urbtracker), GFP_ATOMIC);
@@ -476,7 +472,7 @@ static inline void parport_epilogue(struct parport *pp) 
static void parport_mos7715_write_data(struct parport *pp, unsigned char d)

{

	struct mos7715_parport *mos_parport = pp->private_data;

	dbg("%s called: %2.2x", __func__, d);



	if (parport_prologue(pp) < 0)

		return;

	mos7715_change_mode(mos_parport, SPP);
@@ -488,7 +484,7 @@ static unsigned char parport_mos7715_read_data(struct parport *pp) 
{

	struct mos7715_parport *mos_parport = pp->private_data;

	unsigned char d;

	dbg("%s called", __func__);



	if (parport_prologue(pp) < 0)

		return 0;

	read_mos_reg(mos_parport->serial, dummy, DPR, &d);
@@ -500,7 +496,7 @@ static void parport_mos7715_write_control(struct parport *pp, unsigned char d) 
{

	struct mos7715_parport *mos_parport = pp->private_data;

	__u8 data;

	dbg("%s called: %2.2x", __func__, d);



	if (parport_prologue(pp) < 0)

		return;

	data = ((__u8)d & 0x0f) | (mos_parport->shadowDCR & 0xf0);
@@ -513,7 +509,7 @@ static unsigned char parport_mos7715_read_control(struct parport *pp) 
{

	struct mos7715_parport *mos_parport = pp->private_data;

	__u8 dcr;

	dbg("%s called", __func__);



	spin_lock(&release_lock);

	mos_parport = pp->private_data;

	if (unlikely(mos_parport == NULL)) {
@@ -531,7 +527,7 @@ static unsigned char parport_mos7715_frob_control(struct parport *pp, 
{

	struct mos7715_parport *mos_parport = pp->private_data;

	__u8 dcr;

	dbg("%s called", __func__);



	mask &= 0x0f;

	val &= 0x0f;

	if (parport_prologue(pp) < 0)
@@ -547,7 +543,7 @@ static unsigned char parport_mos7715_read_status(struct parport *pp) 
{

	unsigned char status;

	struct mos7715_parport *mos_parport = pp->private_data;

	dbg("%s called", __func__);



	spin_lock(&release_lock);

	mos_parport = pp->private_data;

	if (unlikely(mos_parport == NULL)) {	/* release called */
@@ -561,17 +557,16 @@ static unsigned char parport_mos7715_read_status(struct parport *pp) 


static void parport_mos7715_enable_irq(struct parport *pp)

{

	dbg("%s called", __func__);

}



static void parport_mos7715_disable_irq(struct parport *pp)

{

	dbg("%s called", __func__);

}



static void parport_mos7715_data_forward(struct parport *pp)

{

	struct mos7715_parport *mos_parport = pp->private_data;

	dbg("%s called", __func__);



	if (parport_prologue(pp) < 0)

		return;

	mos7715_change_mode(mos_parport, PS2);
@@ -583,7 +578,7 @@ static void parport_mos7715_data_forward(struct parport *pp) 
static void parport_mos7715_data_reverse(struct parport *pp)

{

	struct mos7715_parport *mos_parport = pp->private_data;

	dbg("%s called", __func__);



	if (parport_prologue(pp) < 0)

		return;

	mos7715_change_mode(mos_parport, PS2);
@@ -595,7 +590,6 @@ static void parport_mos7715_data_reverse(struct parport *pp) 
static void parport_mos7715_init_state(struct pardevice *dev,

				       struct parport_state *s)

{

	dbg("%s called", __func__);

	s->u.pc.ctr = DCR_INIT_VAL;

	s->u.pc.ecr = ECR_INIT_VAL;

}
@@ -605,7 +599,7 @@ static void parport_mos7715_save_state(struct parport *pp, 
				       struct parport_state *s)

{

	struct mos7715_parport *mos_parport;

	dbg("%s called", __func__);



	spin_lock(&release_lock);

	mos_parport = pp->private_data;

	if (unlikely(mos_parport == NULL)) {	/* release called */
@@ -622,7 +616,7 @@ static void parport_mos7715_restore_state(struct parport *pp, 
					  struct parport_state *s)

{

	struct mos7715_parport *mos_parport;

	dbg("%s called", __func__);



	spin_lock(&release_lock);

	mos_parport = pp->private_data;

	if (unlikely(mos_parport == NULL)) {	/* release called */
@@ -641,7 +635,7 @@ static size_t parport_mos7715_write_compat(struct parport *pp, 
	int retval;

	struct mos7715_parport *mos_parport = pp->private_data;

	int actual_len;

	dbg("%s called: %u chars", __func__, (unsigned int)len);



	if (parport_prologue(pp) < 0)

		return 0;

	mos7715_change_mode(mos_parport, PPF);