Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9815232 authored by Pali Rohár's avatar Pali Rohár Committed by Dmitry Torokhov
Browse files

Input: alps - warn about unsupported ALPS V9 touchpad 



Support for devices with ALPS_PROTO_V9 is not implemented yet but we can
detect these alps touchpads and warn users about it.

Signed-off-by: default avatarPali Rohár <pali.rohar@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 09c398bc

drivers/input/mouse/alps.c

+10 −0
Original line number Diff line number Diff line
@@ -164,6 +164,10 @@ static const struct alps_protocol_info alps_v8_protocol_data = { 
	ALPS_PROTO_V8, 0x18, 0x18, 0

};



static const struct alps_protocol_info alps_v9_protocol_data = {

	ALPS_PROTO_V9, 0xc8, 0xc8, 0

};



/*

 * Some v2 models report the stick buttons in separate bits

 */
@@ -2838,6 +2842,12 @@ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv) 
		} else if (e7[0] == 0x73 && e7[1] == 0x03 &&

			   e7[2] == 0x28 && ec[1] == 0x01) {

			protocol = &alps_v8_protocol_data;

		} else if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0xc8) {

			protocol = &alps_v9_protocol_data;

			psmouse_warn(psmouse,

				     "Unsupported ALPS V9 touchpad: E7=%3ph, EC=%3ph\n",

				     e7, ec);

			return -EINVAL;

		} else {

			psmouse_dbg(psmouse,

				    "Likely not an ALPS touchpad: E7=%3ph, EC=%3ph\n", e7, ec);

drivers/input/mouse/alps.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#define ALPS_PROTO_V6		0x600

#define ALPS_PROTO_V7		0x700	/* t3btl t4s */

#define ALPS_PROTO_V8		0x800	/* SS4btl SS4s */

#define ALPS_PROTO_V9		0x900	/* ss3btl */



#define MAX_TOUCHES	4