Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c84401c2 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

[media] wl128x: Replace memcpy with struct assignment 

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2b9b325d

drivers/media/radio/wl128x/fmdrv_common.c

+1 −2
Original line number Diff line number Diff line
@@ -1563,8 +1563,7 @@ int fmc_prepare(struct fmdev *fmdev) 
	fmdev->irq_info.mask = FM_MAL_EVENT;



	/* Region info */

	memcpy(&fmdev->rx.region, &region_configs[default_radio_region],

			sizeof(struct region_info));

	fmdev->rx.region = region_configs[default_radio_region];



	fmdev->rx.mute_mode = FM_MUTE_OFF;

	fmdev->rx.rf_depend_mute = FM_RX_RF_DEPENDENT_MUTE_OFF;