Commit c7dfc2fa authored Apr 09, 2017 by Carlo Caione Committed by Darren Hart (VMware) Apr 14, 2017

platform/x86: hp-wmi: Fix error value for hp_wmi_tablet_state



hp_wmi_tablet_state() fails to return the correct error code when
hp_wmi_perform_query() returns the HP WMI query specific error code
that is a positive value.

Signed-off-by: Carlo Caione <carlo@endlessm.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>

parent 05aa43cc

drivers/platform/x86/hp-wmi.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -290,7 +290,7 @@ static int hp_wmi_tablet_state(void)
	int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,		int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,
	sizeof(state), sizeof(state));		sizeof(state), sizeof(state));
	if (ret)		if (ret)
	return ret;		return -EINVAL;

	return (state & 0x4) ? 1 : 0;		return (state & 0x4) ? 1 : 0;
	}		}