Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7aef4f8 authored by Jan Kardell's avatar Jan Kardell Committed by Linus Torvalds
Browse files

rtc: pcf8563: fix wrong time from read_alarm 



Incorrect mask was used for hour and monthday fields.

Signed-off-by: default avatarJan Kardell <jan.kardell@telliq.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Vincent Donnefort <vdonnefort@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 45ef0458

drivers/rtc/rtc-pcf8563.c

+2 −2
Original line number Diff line number Diff line
@@ -336,8 +336,8 @@ static int pcf8563_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *tm) 
		__func__, buf[0], buf[1], buf[2], buf[3]);



	tm->time.tm_min = bcd2bin(buf[0] & 0x7F);

	tm->time.tm_hour = bcd2bin(buf[1] & 0x7F);

	tm->time.tm_mday = bcd2bin(buf[2] & 0x1F);

	tm->time.tm_hour = bcd2bin(buf[1] & 0x3F);

	tm->time.tm_mday = bcd2bin(buf[2] & 0x3F);

	tm->time.tm_wday = bcd2bin(buf[3] & 0x7);

	tm->time.tm_mon = -1;

	tm->time.tm_year = -1;