Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c772aa92 authored by Pavel Shilovsky's avatar Pavel Shilovsky Committed by Steve French
Browse files

CIFS: Fix wrong buffer pointer usage in smb_set_file_info 



Commit 6bdf6dbd caused a regression
in setattr codepath that leads to files with wrong attributes.

Signed-off-by: default avatarPavel Shilovsky <piastry@etersoft.ru>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent 3a98b861

fs/cifs/smb1ops.c

+1 −2
Original line number Diff line number Diff line
@@ -766,7 +766,6 @@ smb_set_file_info(struct inode *inode, const char *full_path, 
	struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);

	struct tcon_link *tlink = NULL;

	struct cifs_tcon *tcon;

	FILE_BASIC_INFO info_buf;



	/* if the file is already open for write, just use that fileid */

	open_file = find_writable_file(cinode, true);
@@ -817,7 +816,7 @@ smb_set_file_info(struct inode *inode, const char *full_path, 
	netpid = current->tgid;



set_via_filehandle:

	rc = CIFSSMBSetFileInfo(xid, tcon, &info_buf, netfid, netpid);

	rc = CIFSSMBSetFileInfo(xid, tcon, buf, netfid, netpid);

	if (!rc)

		cinode->cifsAttrs = le32_to_cpu(buf->Attributes);