Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c718a546 authored by Danny Kukawka's avatar Danny Kukawka Committed by Florian Tobias Schandinat
Browse files

riva/fbdev: fix several -Wuninitialized 



Fix several -Wuninitialized compiler warnings by changing the
order of getting modedb in riva_update_default_var() to set
first the fallback and then the prefered timing.

Signed-off-by: default avatarDanny Kukawka <danny.kukawka@bisect.de>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent c6d242aa

drivers/video/riva/fbdev.c

+2 −3
Original line number Diff line number Diff line
@@ -1816,6 +1816,8 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var, 
			     specs->modedb, specs->modedb_len,

			     NULL, 8);

	} else if (specs->modedb != NULL) {

		/* get first mode in database as fallback */

		modedb = specs->modedb[0];

		/* get preferred timing */

		if (info->monspecs.misc & FB_MISC_1ST_DETAIL) {

			int i;
@@ -1826,9 +1828,6 @@ static void __devinit riva_update_default_var(struct fb_var_screeninfo *var, 
					break;

				}

			}

		} else {

			/* otherwise, get first mode in database */

			modedb = specs->modedb[0];

		}

		var->bits_per_pixel = 8;

		riva_update_var(var, &modedb);