Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c59f29cb authored by Pavankumar Kondeti's avatar Pavankumar Kondeti Committed by Steven Rostedt
Browse files

tracing: Use SOFTIRQ_OFFSET for softirq dectection for more accurate results 

The 's' flag is supposed to indicate that a softirq is running. This
can be detected by testing the preempt_count with SOFTIRQ_OFFSET.

The current code tests the preempt_count with SOFTIRQ_MASK, which
would be true even when softirqs are disabled but not serving a
softirq.

Link: http://lkml.kernel.org/r/1481300417-3564-1-git-send-email-pkondeti@codeaurora.org



Signed-off-by: default avatarPavankumar Kondeti <pkondeti@codeaurora.org>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 1a414428

kernel/trace/trace.c

+1 −1
Original line number Diff line number Diff line
@@ -1949,7 +1949,7 @@ tracing_generic_entry_update(struct trace_entry *entry, unsigned long flags, 
#endif

		((pc & NMI_MASK    ) ? TRACE_FLAG_NMI     : 0) |

		((pc & HARDIRQ_MASK) ? TRACE_FLAG_HARDIRQ : 0) |

		((pc & SOFTIRQ_MASK) ? TRACE_FLAG_SOFTIRQ : 0) |

		((pc & SOFTIRQ_OFFSET) ? TRACE_FLAG_SOFTIRQ : 0) |

		(tif_need_resched() ? TRACE_FLAG_NEED_RESCHED : 0) |

		(test_preempt_need_resched() ? TRACE_FLAG_PREEMPT_RESCHED : 0);

}