Commit c4c0edfb authored Nov 18, 2015 by Julia Lawall Committed by Sebastian Reichel Dec 05, 2015

power/reset: at91-reset: add missing of_node_put

for_each_matching_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
expression e,e1;
local idexpression np;
@@

 for_each_matching_node(np, e1) {
   ... when != of_node_put(np)
       when != e = np
(
   return np;
|
+  of_node_put(np);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

parent 79fbdb66

drivers/power/reset/at91-reset.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -198,6 +198,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
	at91_ramc_base[idx] = of_iomap(np, 0);		at91_ramc_base[idx] = of_iomap(np, 0);
	if (!at91_ramc_base[idx]) {		if (!at91_ramc_base[idx]) {
	dev_err(&pdev->dev, "Could not map ram controller address\n");		dev_err(&pdev->dev, "Could not map ram controller address\n");
			of_node_put(np);
	return -ENODEV;		return -ENODEV;
	}		}
	idx++;		idx++;