Commit c4a3f13c authored May 21, 2015 by Brian Norris

mtd: blktrans: use better error code for unimplemented ioctl()



In commit 50183936 ("mtd: blktrans: change blktrans_getgeo return
value") we fixed the problem that ioctl(HDIO_GETGEO) might return 0
(success) for mtdblock devices which did not implement the feature and
would leave a blank (zero) result.

But now, let's get the error code right. Other code paths on this ioctl
tend to use -ENOTTY to notify the user that the ioctl() is not supported
for the device, so let's use that instead of -EOPNOTSUPP.

Suggested-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent 01d0afdd

drivers/mtd/mtd_blkdevs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -278,7 +278,7 @@ static int blktrans_getgeo(struct block_device bdev, struct hd_geometry geo)
		if (!dev->mtd)
		goto unlock;

		ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : -EOPNOTSUPP;
		ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : -ENOTTY;
		unlock:
		mutex_unlock(&dev->lock);
		blktrans_dev_put(dev);