Commit c3423563 authored Mar 03, 2017 by Christoph Hellwig Committed by Greg Kroah-Hartman Mar 16, 2017

vmw_vmci: handle the return value from pci_alloc_irq_vectors correctly



It returns the number of vectors allocated when successful, so check for
a negative error only.

Fixes: 3bb434cd ("vmw_vmci: switch to pci_irq_alloc_vectors")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Loïc Yhuel <loic.yhuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9a69645d

drivers/misc/vmw_vmci/vmci_guest.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -566,10 +566,10 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
		*/
		error = pci_alloc_irq_vectors(pdev, VMCI_MAX_INTRS, VMCI_MAX_INTRS,
		PCI_IRQ_MSIX);
		if (error) {
		if (error < 0) {
		error = pci_alloc_irq_vectors(pdev, 1, 1,
		PCI_IRQ_MSIX \| PCI_IRQ_MSI \| PCI_IRQ_LEGACY);
		if (error)
		if (error < 0)
		goto err_remove_bitmap;
		} else {
		vmci_dev->exclusive_vectors = true;