Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c24a1710 authored by Roland Dreier's avatar Roland Dreier Committed by James Bottomley
Browse files

[SCSI] mpt2sas: Fix leak on mpt2sas_base_attach() error path 



Commit 911ae943 ("[SCSI] mpt2sas: Added NUNA IO support in driver
which uses multi-reply queue support of the HBA") added new
allocations to the beginning of mpt2sas_base_attach(), which means
directly returning an error on failure of mpt2sas_base_map_resources()
will leak those allocations.

Fix this by doing "goto out_free_resources" in this place too, as the
rest of the function does.

Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Acked-by: default avatar"Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent dab2f6b8

drivers/scsi/mpt2sas/mpt2sas_base.c

+1 −1
Original line number Diff line number Diff line
@@ -4256,7 +4256,7 @@ mpt2sas_base_attach(struct MPT2SAS_ADAPTER *ioc) 


	r = mpt2sas_base_map_resources(ioc);

	if (r)

		return r;

		goto out_free_resources;



	if (ioc->is_warpdrive) {

		ioc->reply_post_host_index[0] =