Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c19483cc authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

bluetooth: Fix missing NULL check 



Fortunately this is only exploitable on very unusual hardware.

[Reported a while ago but nothing happened so just fixing it]

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d4429f60

drivers/bluetooth/hci_ldisc.c

+7 −0
Original line number Diff line number Diff line
@@ -256,9 +256,16 @@ static int hci_uart_tty_open(struct tty_struct *tty) 


	BT_DBG("tty %p", tty);



	/* FIXME: This btw is bogus, nothing requires the old ldisc to clear

	   the pointer */

	if (hu)

		return -EEXIST;



	/* Error if the tty has no write op instead of leaving an exploitable

	   hole */

	if (tty->ops->write == NULL)

		return -EOPNOTSUPP;



	if (!(hu = kzalloc(sizeof(struct hci_uart), GFP_KERNEL))) {

		BT_ERR("Can't allocate control structure");

		return -ENFILE;