Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0935f1e authored by Devesh Sharma's avatar Devesh Sharma Committed by Greg Kroah-Hartman
Browse files

RDMA/bnxt_re: Unpin SQ and RQ memory if QP create fails 



[ Upstream commit 6b4521f5174c26020ae0deb3ef7f2c28557cf445 ]

Driver leaves the QP memory pinned if QP create command
fails from the FW. Avoids this scenario by adding a proper
exit path if the FW command fails.

Signed-off-by: default avatarDevesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c5c0632b

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+8 −1
Original line number Diff line number Diff line
@@ -1180,7 +1180,7 @@ struct ib_qp *bnxt_re_create_qp(struct ib_pd *ib_pd, 
		rc = bnxt_qplib_create_qp(&rdev->qplib_res, &qp->qplib_qp);

		if (rc) {

			dev_err(rdev_to_dev(rdev), "Failed to create HW QP");

			goto fail;

			goto free_umem;

		}

	}
@@ -1208,6 +1208,13 @@ struct ib_qp *bnxt_re_create_qp(struct ib_pd *ib_pd, 
	return &qp->ib_qp;

qp_destroy:

	bnxt_qplib_destroy_qp(&rdev->qplib_res, &qp->qplib_qp);

free_umem:

	if (udata) {

		if (qp->rumem)

			ib_umem_release(qp->rumem);

		if (qp->sumem)

			ib_umem_release(qp->sumem);

	}

fail:

	kfree(qp);

	return ERR_PTR(rc);