Commit c03967eb authored Dec 12, 2020 by Christophe JAILLET Committed by Greg Kroah-Hartman Mar 03, 2021

media: vsp1: Fix an error handling path in the probe function



[ Upstream commit 7113469dafc2d545fa4fa9bc649c31dc27db492e ]

A previous 'rcar_fcp_get()' call must be undone in the error handling path,
as already done in the remove function.

Fixes: 94fcdf82 ("[media] v4l: vsp1: Add FCP support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 717aeb38

drivers/media/platform/vsp1/vsp1_drv.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -866,8 +866,10 @@ static int vsp1_probe(struct platform_device *pdev)
		}

		done:
		if (ret)
		if (ret) {
		pm_runtime_disable(&pdev->dev);
		rcar_fcp_put(vsp1->fcp);
		}

		return ret;
		}