Commit bfe29677 authored Nov 17, 2008 by Pablo Neira Ayuso Committed by Patrick McHardy Nov 17, 2008

netfilter: ctnetlink: use EOPNOTSUPP instead of EINVAL if the conntrack has no helper



This patch changes the return value if the conntrack has no helper assigned.
Instead of EINVAL, which is reserved for malformed messages, it returns
EOPNOTSUPP.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>

parent 238ede81

net/netfilter/nf_conntrack_netlink.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1652,7 +1652,7 @@ ctnetlink_create_expect(struct nlattr *cda[], u_int8_t u3)

	if (!help \|\| !help->helper) {		if (!help \|\| !help->helper) {
	/* such conntrack hasn't got any helper, abort */		/* such conntrack hasn't got any helper, abort */
	err = -EINVAL;		err = -EOPNOTSUPP;
	goto out;		goto out;
	}		}