Commit bebb2a47 authored May 23, 2017 by Moni Shoua Committed by Doug Ledford Jul 17, 2017

IB/core: Namespace is mandatory input for address resolution



In function addr_resolve() the namespace is a required input parameter
and not an output. It is passed later for searching the routing table
and device addresses. Also, it shouldn't be copied back to the caller.

Fixes: 565edd1d ('IB/addr: Pass network namespace as a parameter')
Cc: <stable@vger.kernel.org> # v4.3+
Signed-off-by: Moni Shoua <monis@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent c8c16d3b

drivers/infiniband/core/addr.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -509,6 +509,11 @@ static int addr_resolve(struct sockaddr *src_in,
		struct dst_entry *dst;
		int ret;

		if (!addr->net) {
		pr_warn_ratelimited("%s: missing namespace\n", __func__);
		return -EINVAL;
		}

		if (src_in->sa_family == AF_INET) {
		struct rtable *rt = NULL;
		const struct sockaddr_in *dst_in4 =
		@@ -546,7 +551,6 @@ static int addr_resolve(struct sockaddr *src_in,
		}

		addr->bound_dev_if = ndev->ifindex;
		addr->net = dev_net(ndev);
		dev_put(ndev);

		return ret;