Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit beb0a43f authored by Axel Lin's avatar Axel Lin Committed by Richard Purdie
Browse files

backlight: l4f00242t03: fix error handling in l4f00242t03_probe 



Error handling fixes:
1. In the case of kzalloc failure, simple return -ENOMEM instead of goto
   err. ( priv is NULL in this case )
2. In the case of gpio_request fail for reset_gpio and data_enable_gpio,
   properly release resources by goto err and err2 respectively.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarAlberto Panizzo <maramaopercheseimorto@gmail.com>
Signed-off-by: default avatarRichard Purdie <rpurdie@linux.intel.com>
parent ee378a5c

drivers/video/backlight/l4f00242t03.c

+3 −4
Original line number Diff line number Diff line
@@ -125,8 +125,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi) 


	if (priv == NULL) {

		dev_err(&spi->dev, "No memory for this device.\n");

		ret = -ENOMEM;

		goto err;

		return -ENOMEM;

	}



	dev_set_drvdata(&spi->dev, priv);
@@ -139,7 +138,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi) 
	if (ret) {

		dev_err(&spi->dev,

			"Unable to get the lcd l4f00242t03 reset gpio.\n");

		return ret;

		goto err;

	}



	ret = gpio_direction_output(pdata->reset_gpio, 1);
@@ -151,7 +150,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi) 
	if (ret) {

		dev_err(&spi->dev,

			"Unable to get the lcd l4f00242t03 data en gpio.\n");

		return ret;

		goto err2;

	}



	ret = gpio_direction_output(pdata->data_enable_gpio, 0);