Commit bd513989 authored Oct 08, 2017 by Christophe Jaillet Committed by Greg Kroah-Hartman Dec 25, 2017

crypto: lrw - Fix an error handling path in 'create()'




[ Upstream commit 616129cc6e75fb4da6681c16c981fa82dfe5e4c7 ]

All error handling paths 'goto err_drop_spawn' except this one.
In order to avoid some resources leak, we should do it as well here.

Fixes: 700cb3f5 ("crypto: lrw - Convert to skcipher")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 714abd2d

crypto/lrw.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -610,8 +610,10 @@ static int create(struct crypto_template tmpl, struct rtattr *tb)
		ecb_name[len - 1] = 0;

		if (snprintf(inst->alg.base.cra_name, CRYPTO_MAX_ALG_NAME,
		"lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME)
		return -ENAMETOOLONG;
		"lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME) {
		err = -ENAMETOOLONG;
		goto err_drop_spawn;
		}
		}

		inst->alg.base.cra_flags = alg->base.cra_flags & CRYPTO_ALG_ASYNC;