Commit bd1d9855 authored Sep 29, 2008 by Kenji Kaneshige Committed by Jesse Barnes Oct 20, 2008

PCI hotplug: fix get_##name return value problem



The commit 356a9d6f3dd283f83861adf1ac909879f0e66411 (PCI: fix hotplug
get_##name return value problem) doesn't seem to be merged properly.
Because of this, PCI hotplug no longer works (Read/Write PCI hotplug
files always returns -ENODEV).

This patch fixes wrong check of try_module_get() return value check in
get_##name().

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent e5665a45

drivers/pci/hotplug/pci_hotplug_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ static int get_##name (struct hotplug_slot slot, type value) \
		{ \
		struct hotplug_slot_ops *ops = slot->ops; \
		int retval = 0; \
		if (try_module_get(ops->owner)) \
		if (!try_module_get(ops->owner)) \
		return -ENODEV; \
		if (ops->get_##name) \
		retval = ops->get_##name(slot, value); \