Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd1cc771 authored by Mintz, Yuval's avatar Mintz, Yuval Committed by David S. Miller
Browse files

qed: Don't close the OUT_EN during init 



Before initializing the chip's engine, driver currently closes a set
of registers on the HW's ingress flow to prevent packets from slipping
in while they're not supposed to.

This configuration is insufficient, as there are some scenarios where
packets would still arrive even when said registers are set,
but the management firmware already closes other per-port registers
that do suffice, making this setting unnecessray.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 60afed72

drivers/net/ethernet/qlogic/qed/qed_dev.c

+0 −12
Original line number Diff line number Diff line
@@ -1279,18 +1279,6 @@ static int qed_hw_init_common(struct qed_hwfn *p_hwfn, 


	qed_cxt_hw_init_common(p_hwfn);



	/* Close gate from NIG to BRB/Storm; By default they are open, but

	 * we close them to prevent NIG from passing data to reset blocks.

	 * Should have been done in the ENGINE phase, but init-tool lacks

	 * proper port-pretend capabilities.

	 */

	qed_wr(p_hwfn, p_ptt, NIG_REG_RX_BRB_OUT_EN, 0);

	qed_wr(p_hwfn, p_ptt, NIG_REG_STORM_OUT_EN, 0);

	qed_port_pretend(p_hwfn, p_ptt, p_hwfn->port_id ^ 1);

	qed_wr(p_hwfn, p_ptt, NIG_REG_RX_BRB_OUT_EN, 0);

	qed_wr(p_hwfn, p_ptt, NIG_REG_STORM_OUT_EN, 0);

	qed_port_unpretend(p_hwfn, p_ptt);



	qed_init_cache_line_size(p_hwfn, p_ptt);



	rc = qed_init_run(p_hwfn, p_ptt, PHASE_ENGINE, ANY_PHASE_ID, hw_mode);