Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bca34c9a authored by YoungJun Cho's avatar YoungJun Cho Committed by Inki Dae
Browse files

drm/exynos: Remove tracking log functions 



This patch removes tracking log functions which were used to debug
in the early development stage and are not so important as were.
So remove them for code clean up.

Signed-off-by: default avatarYoungJun Cho <yj44.cho@samsung.com>
Signed-off-by: default avatarSeung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 16844fb1

drivers/gpu/drm/exynos/exynos_drm_buf.c

+0 −7
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, 
	enum dma_attr attr;

	unsigned int nr_pages;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	if (buf->dma_addr) {

		DRM_DEBUG_KMS("already allocated.\n");

		return 0;
@@ -119,8 +117,6 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, 
static void lowlevel_buffer_deallocate(struct drm_device *dev,

		unsigned int flags, struct exynos_drm_gem_buf *buf)

{

	DRM_DEBUG_KMS("%s.\n", __FILE__);



	if (!buf->dma_addr) {

		DRM_DEBUG_KMS("dma_addr is invalid.\n");

		return;
@@ -151,7 +147,6 @@ struct exynos_drm_gem_buf *exynos_drm_init_buf(struct drm_device *dev, 
{

	struct exynos_drm_gem_buf *buffer;



	DRM_DEBUG_KMS("%s.\n", __FILE__);

	DRM_DEBUG_KMS("desired size = 0x%x\n", size);



	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
@@ -167,8 +162,6 @@ struct exynos_drm_gem_buf *exynos_drm_init_buf(struct drm_device *dev, 
void exynos_drm_fini_buf(struct drm_device *dev,

				struct exynos_drm_gem_buf *buffer)

{

	DRM_DEBUG_KMS("%s.\n", __FILE__);



	if (!buffer) {

		DRM_DEBUG_KMS("buffer is null.\n");

		return;

drivers/gpu/drm/exynos/exynos_drm_connector.c

+0 −13
Original line number Diff line number Diff line
@@ -34,7 +34,6 @@ convert_to_display_mode(struct drm_display_mode *mode, 
			struct exynos_drm_panel_info *panel)

{

	struct fb_videomode *timing = &panel->timing;

	DRM_DEBUG_KMS("%s\n", __FILE__);



	mode->clock = timing->pixclock / 1000;

	mode->vrefresh = timing->refresh;
@@ -68,8 +67,6 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector) 
	unsigned int count = 0;

	int ret;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	if (!display_ops) {

		DRM_DEBUG_KMS("display_ops is null.\n");

		return 0;
@@ -156,8 +153,6 @@ struct drm_encoder *exynos_drm_best_encoder(struct drm_connector *connector) 
	struct drm_mode_object *obj;

	struct drm_encoder *encoder;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	obj = drm_mode_object_find(dev, exynos_connector->encoder_id,

				   DRM_MODE_OBJECT_ENCODER);

	if (!obj) {
@@ -200,8 +195,6 @@ void exynos_drm_display_power(struct drm_connector *connector, int mode) 
static void exynos_drm_connector_dpms(struct drm_connector *connector,

					int mode)

{

	DRM_DEBUG_KMS("%s\n", __FILE__);



	/*

	 * in case that drm_crtc_helper_set_mode() is called,

	 * encoder/crtc->funcs->dpms() will be just returned
@@ -248,8 +241,6 @@ exynos_drm_connector_detect(struct drm_connector *connector, bool force) 
					manager->display_ops;

	enum drm_connector_status status = connector_status_disconnected;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	if (display_ops && display_ops->is_connected) {

		if (display_ops->is_connected(manager->dev))

			status = connector_status_connected;
@@ -265,8 +256,6 @@ static void exynos_drm_connector_destroy(struct drm_connector *connector) 
	struct exynos_drm_connector *exynos_connector =

		to_exynos_connector(connector);



	DRM_DEBUG_KMS("%s\n", __FILE__);



	drm_sysfs_connector_remove(connector);

	drm_connector_cleanup(connector);

	kfree(exynos_connector);
@@ -288,8 +277,6 @@ struct drm_connector *exynos_drm_connector_create(struct drm_device *dev, 
	int type;

	int err;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	exynos_connector = kzalloc(sizeof(*exynos_connector), GFP_KERNEL);

	if (!exynos_connector) {

		DRM_ERROR("failed to allocate connector\n");

drivers/gpu/drm/exynos/exynos_drm_core.c

+0 −12
Original line number Diff line number Diff line
@@ -27,8 +27,6 @@ static int exynos_drm_create_enc_conn(struct drm_device *dev, 
	struct drm_connector *connector;

	int ret;



	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	subdrv->manager->dev = subdrv->dev;



	/* create and initialize a encoder for this sub driver. */
@@ -102,8 +100,6 @@ static int exynos_drm_subdrv_probe(struct drm_device *dev, 
static void exynos_drm_subdrv_remove(struct drm_device *dev,

				      struct exynos_drm_subdrv *subdrv)

{

	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	if (subdrv->remove)

		subdrv->remove(dev, subdrv->dev);

}
@@ -114,8 +110,6 @@ int exynos_drm_device_register(struct drm_device *dev) 
	unsigned int fine_cnt = 0;

	int err;



	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	if (!dev)

		return -EINVAL;
@@ -158,8 +152,6 @@ int exynos_drm_device_unregister(struct drm_device *dev) 
{

	struct exynos_drm_subdrv *subdrv;



	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	if (!dev) {

		WARN(1, "Unexpected drm device unregister!\n");

		return -EINVAL;
@@ -176,8 +168,6 @@ EXPORT_SYMBOL_GPL(exynos_drm_device_unregister); 


int exynos_drm_subdrv_register(struct exynos_drm_subdrv *subdrv)

{

	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	if (!subdrv)

		return -EINVAL;
@@ -189,8 +179,6 @@ EXPORT_SYMBOL_GPL(exynos_drm_subdrv_register); 


int exynos_drm_subdrv_unregister(struct exynos_drm_subdrv *subdrv)

{

	DRM_DEBUG_DRIVER("%s\n", __FILE__);



	if (!subdrv)

		return -EINVAL;

drivers/gpu/drm/exynos/exynos_drm_crtc.c

+0 −28
Original line number Diff line number Diff line
@@ -76,8 +76,6 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) 


static void exynos_drm_crtc_prepare(struct drm_crtc *crtc)

{

	DRM_DEBUG_KMS("%s\n", __FILE__);



	/* drm framework doesn't check NULL. */

}
@@ -85,8 +83,6 @@ static void exynos_drm_crtc_commit(struct drm_crtc *crtc) 
{

	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);



	DRM_DEBUG_KMS("%s\n", __FILE__);



	exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_ON);

	exynos_plane_commit(exynos_crtc->plane);

	exynos_plane_dpms(exynos_crtc->plane, DRM_MODE_DPMS_ON);
@@ -97,8 +93,6 @@ exynos_drm_crtc_mode_fixup(struct drm_crtc *crtc, 
			    const struct drm_display_mode *mode,

			    struct drm_display_mode *adjusted_mode)

{

	DRM_DEBUG_KMS("%s\n", __FILE__);



	/* drm framework doesn't check NULL */

	return true;

}
@@ -115,8 +109,6 @@ exynos_drm_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode, 
	int pipe = exynos_crtc->pipe;

	int ret;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	/*

	 * copy the mode data adjusted by mode_fixup() into crtc->mode

	 * so that hardware can be seet to proper mode.
@@ -148,8 +140,6 @@ static int exynos_drm_crtc_mode_set_commit(struct drm_crtc *crtc, int x, int y, 
	unsigned int crtc_h;

	int ret;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	/* when framebuffer changing is requested, crtc's dpms should be on */

	if (exynos_crtc->dpms > DRM_MODE_DPMS_ON) {

		DRM_ERROR("failed framebuffer changing request.\n");
@@ -179,8 +169,6 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc) 
{

	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);



	DRM_DEBUG_KMS("%s\n", __FILE__);



	exynos_plane_dpms(exynos_crtc->plane, DRM_MODE_DPMS_OFF);

	exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);

}
@@ -205,8 +193,6 @@ static int exynos_drm_crtc_page_flip(struct drm_crtc *crtc, 
	struct drm_framebuffer *old_fb = crtc->fb;

	int ret = -EINVAL;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	/* when the page flip is requested, crtc's dpms should be on */

	if (exynos_crtc->dpms > DRM_MODE_DPMS_ON) {

		DRM_ERROR("failed page flip request.\n");
@@ -259,8 +245,6 @@ static void exynos_drm_crtc_destroy(struct drm_crtc *crtc) 
	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);

	struct exynos_drm_private *private = crtc->dev->dev_private;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	private->crtc[exynos_crtc->pipe] = NULL;



	drm_crtc_cleanup(crtc);
@@ -275,8 +259,6 @@ static int exynos_drm_crtc_set_property(struct drm_crtc *crtc, 
	struct exynos_drm_private *dev_priv = dev->dev_private;

	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);



	DRM_DEBUG_KMS("%s\n", __func__);



	if (property == dev_priv->crtc_mode_property) {

		enum exynos_crtc_mode mode = val;
@@ -321,8 +303,6 @@ static void exynos_drm_crtc_attach_mode_property(struct drm_crtc *crtc) 
	struct exynos_drm_private *dev_priv = dev->dev_private;

	struct drm_property *prop;



	DRM_DEBUG_KMS("%s\n", __func__);



	prop = dev_priv->crtc_mode_property;

	if (!prop) {

		prop = drm_property_create_enum(dev, 0, "mode", mode_names,
@@ -342,8 +322,6 @@ int exynos_drm_crtc_create(struct drm_device *dev, unsigned int nr) 
	struct exynos_drm_private *private = dev->dev_private;

	struct drm_crtc *crtc;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	exynos_crtc = kzalloc(sizeof(*exynos_crtc), GFP_KERNEL);

	if (!exynos_crtc) {

		DRM_ERROR("failed to allocate exynos crtc\n");
@@ -378,8 +356,6 @@ int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int crtc) 
	struct exynos_drm_crtc *exynos_crtc =

		to_exynos_crtc(private->crtc[crtc]);



	DRM_DEBUG_KMS("%s\n", __FILE__);



	if (exynos_crtc->dpms != DRM_MODE_DPMS_ON)

		return -EPERM;
@@ -395,8 +371,6 @@ void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int crtc) 
	struct exynos_drm_crtc *exynos_crtc =

		to_exynos_crtc(private->crtc[crtc]);



	DRM_DEBUG_KMS("%s\n", __FILE__);



	if (exynos_crtc->dpms != DRM_MODE_DPMS_ON)

		return;
@@ -412,8 +386,6 @@ void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc) 
	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(drm_crtc);

	unsigned long flags;



	DRM_DEBUG_KMS("%s\n", __FILE__);



	spin_lock_irqsave(&dev->event_lock, flags);



	list_for_each_entry_safe(e, t, &dev_priv->pageflip_event_list,

drivers/gpu/drm/exynos/exynos_drm_dmabuf.c

+0 −6
Original line number Diff line number Diff line
@@ -71,8 +71,6 @@ static struct sg_table * 
	unsigned int i;

	int nents, ret;



	DRM_DEBUG_PRIME("%s\n", __FILE__);



	/* just return current sgt if already requested. */

	if (exynos_attach->dir == dir && exynos_attach->is_mapped)

		return &exynos_attach->sgt;
@@ -133,8 +131,6 @@ static void exynos_dmabuf_release(struct dma_buf *dmabuf) 
{

	struct exynos_drm_gem_obj *exynos_gem_obj = dmabuf->priv;



	DRM_DEBUG_PRIME("%s\n", __FILE__);



	/*

	 * exynos_dmabuf_release() call means that file object's

	 * f_count is 0 and it calls drm_gem_object_handle_unreference()
@@ -219,8 +215,6 @@ struct drm_gem_object *exynos_dmabuf_prime_import(struct drm_device *drm_dev, 
	struct exynos_drm_gem_buf *buffer;

	int ret;



	DRM_DEBUG_PRIME("%s\n", __FILE__);



	/* is this one of own objects? */

	if (dma_buf->ops == &exynos_dmabuf_ops) {

		struct drm_gem_object *obj;