Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc909f27 authored by Anton Vorontsov's avatar Anton Vorontsov
Browse files

da9052-battery: Fix da9052_determine_vc_tbl_index's return value



The patch fixes the following warnings:

  CHECK   drivers/power/da9052-battery.c
drivers/power/da9052-battery.c:330:15: warning: symbol 'da9052_determine_vc_tbl_index' was not declared. Should it be static?
  CC      drivers/power/da9052-battery.o
drivers/power/da9052-battery.c: In function 'da9052_determine_vc_tbl_index':
drivers/power/da9052-battery.c:348:1: warning: control reaches end of non-void function [-Wreturn-type]

Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
parent 6297b5e5
Loading
Loading
Loading
Loading
+8 −1
Original line number Original line Diff line number Diff line
@@ -327,7 +327,7 @@ static int da9052_bat_interpolate(int vbat_lower, int vbat_upper,
	return tmp;
	return tmp;
}
}


unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp)
static unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp)
{
{
	int i;
	int i;


@@ -345,6 +345,13 @@ unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp)
		     && (adc_temp <= vc_tbl_ref[i]))
		     && (adc_temp <= vc_tbl_ref[i]))
				return i + 1;
				return i + 1;
	}
	}
	/*
	 * For some reason authors of the driver didn't presume that we can
	 * end up here. It might be OK, but might be not, no one knows for
	 * sure. Go check your battery, is it on fire?
	 */
	WARN_ON(1);
	return 0;
}
}


static int da9052_bat_read_capacity(struct da9052_battery *bat, int *capacity)
static int da9052_bat_read_capacity(struct da9052_battery *bat, int *capacity)