Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbc0910d authored by Fenglin Wu's avatar Fenglin Wu
Browse files

spmi: pmic-arb: Remove checking opc value not less than 0 



The opc parameter in pmic_arb_write_cmd() function is defined with type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning during
compilation. Remove the check.

Change-Id: I34a271447b8458107239fb85cbf5cc669b51ff6e
Signed-off-by: default avatarFenglin Wu <fenglinw@codeaurora.org>
parent 7f4dcf0d

drivers/spmi/spmi-pmic-arb.c

+2 −2
Original line number Original line Diff line number Diff line 
/*

/*

 * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.

 * Copyright (c) 2012-2015, 2017, The Linux Foundation. All rights reserved.

 *

 *

 * This program is free software; you can redistribute it and/or modify

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and

 * it under the terms of the GNU General Public License version 2 and
@@ -379,7 +379,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid, 
	/* Check the opcode */

	/* Check the opcode */

	if (opc >= 0x40 && opc <= 0x5F)

	if (opc >= 0x40 && opc <= 0x5F)

		opc = PMIC_ARB_OP_WRITE;

		opc = PMIC_ARB_OP_WRITE;

	else if (opc >= 0x00 && opc <= 0x0F)

	else if (opc <= 0x0F)

		opc = PMIC_ARB_OP_EXT_WRITE;

		opc = PMIC_ARB_OP_EXT_WRITE;

	else if (opc >= 0x30 && opc <= 0x37)

	else if (opc >= 0x30 && opc <= 0x37)

		opc = PMIC_ARB_OP_EXT_WRITEL;

		opc = PMIC_ARB_OP_EXT_WRITEL;