Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba3706c0 authored by YoungJun Cho's avatar YoungJun Cho Committed by Inki Dae
Browse files

drm/exynos: add error check routine in exynos_drm_open 



When the exynos_drm_subdrv_open() returns error, the file_priv
should be released and file->driver_priv set to NULL.

Signed-off-by: default avatarYoungJun Cho <yj44.cho@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 782953ec

drivers/gpu/drm/exynos/exynos_drm_drv.c

+8 −1
Original line number Original line Diff line number Diff line
@@ -155,6 +155,7 @@ static int exynos_drm_unload(struct drm_device *dev) 
static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)

static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)

{

{

	struct drm_exynos_file_private *file_priv;

	struct drm_exynos_file_private *file_priv;

	int ret;





	file_priv = kzalloc(sizeof(*file_priv), GFP_KERNEL);

	file_priv = kzalloc(sizeof(*file_priv), GFP_KERNEL);

	if (!file_priv)

	if (!file_priv)
@@ -162,7 +163,13 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) 




	file->driver_priv = file_priv;

	file->driver_priv = file_priv;





	return exynos_drm_subdrv_open(dev, file);

	ret = exynos_drm_subdrv_open(dev, file);

	if (ret) {

		kfree(file_priv);

		file->driver_priv = NULL;

	}



	return ret;

}

}





static void exynos_drm_preclose(struct drm_device *dev,

static void exynos_drm_preclose(struct drm_device *dev,