Commit b7f1129a authored Mar 07, 2018 by Stephen Hemminger Committed by Greg Kroah-Hartman May 30, 2018

hv_netvsc: fix locking during VF setup



[ Upstream commit b0dee7910317f41f398838992516af6a3b981d86 ]

The dev_uc/mc_sync calls need to have the device address list
locked. This was spotted by running with lockdep enabled.

Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b37bc05f

drivers/net/hyperv/netvsc_drv.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1848,8 +1848,12 @@ static void __netvsc_vf_setup(struct net_device *ndev,

		/* set multicast etc flags on VF */
		dev_change_flags(vf_netdev, ndev->flags \| IFF_SLAVE);

		/* sync address list from ndev to VF */
		netif_addr_lock_bh(ndev);
		dev_uc_sync(vf_netdev, ndev);
		dev_mc_sync(vf_netdev, ndev);
		netif_addr_unlock_bh(ndev);

		if (netif_running(ndev)) {
		ret = dev_open(vf_netdev);