Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b76d8aa0 authored by Tokunori Ikegami's avatar Tokunori Ikegami Committed by Greg Kroah-Hartman
Browse files

mtd: cfi_cmdset_0002: Change erase functions to retry for error 



commit 45f75b8a919a4255f52df454f1ffdee0e42443b2 upstream.

For the word write functions it is retried for error.
But it is not implemented to retry for the erase functions.
To make sure for the erase functions change to retry as same.

This is needed to prevent the flash erase error caused only once.
It was caused by the error case of chip_good() in the do_erase_oneblock().
Also it was confirmed on the MACRONIX flash device MX29GL512FHT2I-11G.
But the error issue behavior is not able to reproduce at this moment.
The flash controller is parallel Flash interface integrated on BCM53003.

Signed-off-by: default avatarTokunori Ikegami <ikegami@allied-telesis.co.jp>
Reviewed-by: default avatarJoakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb638a00

drivers/mtd/chips/cfi_cmdset_0002.c

+10 −0
Original line number Diff line number Diff line
@@ -2241,6 +2241,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) 
	unsigned long int adr;

	DECLARE_WAITQUEUE(wait, current);

	int ret = 0;

	int retry_cnt = 0;



	adr = cfi->addr_unlock1;
@@ -2258,6 +2259,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) 
	ENABLE_VPP(map);

	xip_disable(map, chip, adr);



 retry:

	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);

	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
@@ -2312,6 +2314,9 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) 
		map_write( map, CMD(0xF0), chip->start );

		/* FIXME - should have reset delay before continuing */



		if (++retry_cnt <= MAX_RETRIES)

			goto retry;



		ret = -EIO;

	}
@@ -2331,6 +2336,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, 
	unsigned long timeo = jiffies + HZ;

	DECLARE_WAITQUEUE(wait, current);

	int ret = 0;

	int retry_cnt = 0;



	adr += chip->start;
@@ -2348,6 +2354,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, 
	ENABLE_VPP(map);

	xip_disable(map, chip, adr);



 retry:

	cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

	cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);

	cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);
@@ -2405,6 +2412,9 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, 
		map_write( map, CMD(0xF0), chip->start );

		/* FIXME - should have reset delay before continuing */



		if (++retry_cnt <= MAX_RETRIES)

			goto retry;



		ret = -EIO;

	}