Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b66f55cd authored by Geert Uytterhoeven's avatar Geert Uytterhoeven
Browse files

m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn 



If max_pfn is not initialized, the block layer may use wrong DMA masks.

Replace open-coded shifts by PFN_DOWN(), and drop the "0 on coldfire"
comment, as it is not even true on all Coldfires, let alone all
m68knommu platforms.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: default avatarGreg Ungerer <gerg@uclinux.org>
Tested-By: default avatarGreg Ungerer <gerg@uclinux.org>
parent c73ec319

arch/m68k/kernel/setup_no.c

+6 −3
Original line number Original line Diff line number Diff line
@@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) 
	 * Give all the memory to the bootmap allocator, tell it to put the

	 * Give all the memory to the bootmap allocator, tell it to put the

	 * boot mem_map at the start of memory.

	 * boot mem_map at the start of memory.

	 */

	 */

	min_low_pfn = PFN_DOWN(memory_start);

	max_pfn = max_low_pfn = PFN_DOWN(memory_end);



	bootmap_size = init_bootmem_node(

	bootmap_size = init_bootmem_node(

			NODE_DATA(0),

			NODE_DATA(0),

			memory_start >> PAGE_SHIFT, /* map goes here */

			min_low_pfn,		/* map goes here */

			PAGE_OFFSET >> PAGE_SHIFT,	/* 0 on coldfire */

			PFN_DOWN(PAGE_OFFSET),

			memory_end >> PAGE_SHIFT);

			max_pfn);

	/*

	/*

	 * Free the usable memory, we have to make sure we do not free

	 * Free the usable memory, we have to make sure we do not free

	 * the bootmem bitmap so we then reserve it after freeing it :-)

	 * the bootmem bitmap so we then reserve it after freeing it :-)