Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b61d92d8 authored by Sean Hefty's avatar Sean Hefty Committed by Roland Dreier
Browse files

IB/mad: Fix incorrect access to items on local_list 



In cancel_mads(), MADs are moved from the wait_list and local_list
to a cancel_list for processing.  However, the structures on these two
lists are not the same.  The wait_list references struct
ib_mad_send_wr_private, but local_list references struct
ib_mad_local_private.  Cancel_mads() treats all items moved to the
cancel_list as struct ib_mad_send_wr_private.  This leads to a system
crash when requests are moved from the local_list to the cancel_list.

Fix this by leaving local_list alone.  All requests on the local_list
have completed are just awaiting processing by a queued worker thread.

Bug (crash) reported by Dotan Barak <dotanb@dev.mellanox.co.il>.
Problem with local_list access reported by Robert Reynolds
<rreynolds@opengridcomputing.com>.

Signed-off-by: default avatarSean Hefty <sean.hefty@intel.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 9af57b7a

drivers/infiniband/core/mad.c

+0 −2
Original line number Diff line number Diff line
@@ -2275,8 +2275,6 @@ static void cancel_mads(struct ib_mad_agent_private *mad_agent_priv) 


	/* Empty wait list to prevent receives from finding a request */

	list_splice_init(&mad_agent_priv->wait_list, &cancel_list);

	/* Empty local completion list as well */

	list_splice_init(&mad_agent_priv->local_list, &cancel_list);

	spin_unlock_irqrestore(&mad_agent_priv->lock, flags);



	/* Report all cancelled requests */